-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deployment and auth links to align with Next.js App Router #71589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current stytch link points to javascript-example, new URL now points to correct next.js docs for the stytch auth
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
ijjk
approved these changes
Oct 29, 2024
kdy1
pushed a commit
that referenced
this pull request
Oct 30, 2024
This PR addresses the following fixes: **fix: update the deployment link to Next.js App Router** - Updated the deployment link to point to the Next.js App Router instead of the Pages Router since the example now has the pages router **fix: App Router deployment link for app-dir-i18n-routing example** - Corrected the deployment link for the app-dir-i18n-routing example to match the App Router deployment structure. **fix: Stytch auth link updated to Next.js** - Updated the Stytch authentication link to work with the Next.js setup, previous link was pointed to Javascript example. --------- Co-authored-by: JJ Kasper <jj@jjsweb.site>
stipsan
pushed a commit
to sanity-io/next.js
that referenced
this pull request
Nov 6, 2024
…l#71589) This PR addresses the following fixes: **fix: update the deployment link to Next.js App Router** - Updated the deployment link to point to the Next.js App Router instead of the Pages Router since the example now has the pages router **fix: App Router deployment link for app-dir-i18n-routing example** - Corrected the deployment link for the app-dir-i18n-routing example to match the App Router deployment structure. **fix: Stytch auth link updated to Next.js** - Updated the Stytch authentication link to work with the Next.js setup, previous link was pointed to Javascript example. --------- Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following fixes:
fix: update the deployment link to Next.js App Router
fix: App Router deployment link for app-dir-i18n-routing example
fix: Stytch auth link updated to Next.js